Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ApplicationAssessmentPageHeader refactor to remove useEntityModal #1246

Merged
merged 4 commits into from
Aug 8, 2023
Merged

✨ ApplicationAssessmentPageHeader refactor to remove useEntityModal #1246

merged 4 commits into from
Aug 8, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Aug 3, 2023

  • Replace UseEntityModal with local state "standard" approach we now use
  • Remove useEntityModal hook which is not used anymore.

Resolves #1234

@gildub gildub requested a review from ibolton336 August 3, 2023 15:01
@gildub gildub changed the title ✨ ApplicationAssessmentPageHeeader refactor to remove useEntityModal ✨ ApplicationAssessmentPageHeader refactor to remove useEntityModal Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 9.92% and project coverage change: -0.51% ⚠️

Comparison is base (1ff5686) 44.15% compared to head (e6898b4) 43.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
- Coverage   44.15%   43.64%   -0.51%     
==========================================
  Files         177      173       -4     
  Lines        4482     4454      -28     
  Branches     1026     1035       +9     
==========================================
- Hits         1979     1944      -35     
- Misses       2428     2431       +3     
- Partials       75       79       +4     
Flag Coverage Δ
client 43.64% <9.92%> (-0.51%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/common/CustomRules/rules-utils.tsx 7.57% <ø> (-1.12%) ⬇️
client/src/app/components/target-card.tsx 18.18% <0.00%> (-2.79%) ⬇️
...s/applications/analysis-wizard/analysis-wizard.tsx 68.54% <0.00%> (+0.29%) ⬆️
.../app/pages/applications/analysis-wizard/review.tsx 18.60% <0.00%> (-3.02%) ⬇️
...pages/applications/analysis-wizard/set-targets.tsx 10.95% <1.92%> (+1.43%) ⬆️
...pages/applications/analysis-wizard/set-options.tsx 16.32% <4.05%> (-5.11%) ⬇️
...ages/applications/analysis-wizard/custom-rules.tsx 14.78% <6.25%> (+0.78%) ⬆️
client/src/app/queries/targets.ts 16.00% <16.00%> (ø)
...ssment-page/application-assessment-page-header.tsx 64.70% <33.33%> (-7.17%) ⬇️
client/src/app/api/rest.ts 55.02% <55.55%> (+0.02%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gildub gildub self-assigned this Aug 4, 2023
@ibolton336
Copy link
Member

LGTM

gildub added 4 commits August 8, 2023 12:52
Signed-off-by: Gilles Dubreuil <[email protected]>
@gildub gildub merged commit 67c8881 into konveyor:main Aug 8, 2023
@gildub gildub deleted the appassesspageheader-refactor-useEntityModal branch August 8, 2023 12:20
ibolton336 pushed a commit to ibolton336/tackle2-ui that referenced this pull request Aug 8, 2023
…onveyor#1246)

- Replace UseEntityModal with local state "standard" approach we now use
- Remove useEntityModal hook which is not used anymore.

Resolves konveyor#1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace useEntityModal with local state approach
2 participants