-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Jobfunctions: Update Notification and refactors update/create modal and queries #1209
✨ Jobfunctions: Update Notification and refactors update/create modal and queries #1209
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
+ Coverage 44.03% 44.05% +0.01%
==========================================
Files 177 177
Lines 4517 4515 -2
Branches 1007 1007
==========================================
Hits 1989 1989
+ Misses 2517 2515 -2
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Is the new syntax really called RQ mutations? Seems like those are two distinct things: a query or a mutation. With a mutation modifying data on a server & a query just fetching data. |
client/src/app/pages/controls/job-functions/components/job-function-form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Gilles Dubreuil <[email protected]>
Signed-off-by: Gilles Dubreuil <[email protected]>
Signed-off-by: Gilles Dubreuil <[email protected]>
While resolving the related notification issues (see associated MTA-1024) ) this also refactors create/update modal and tries to bring more consistency.
Includes following changes :
Partially address https://issues.redhat.com/browse/MTA-1024