-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (various): styling issues with pf-v5-m vs pf-m #1177
Conversation
e273362
to
31d3d89
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 44.09% 44.09%
=======================================
Files 177 177
Lines 4499 4499
Branches 1007 1007
=======================================
Hits 1984 1984
Misses 2504 2504
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
23df803
to
5e21721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
5e21721
to
632dd82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gitdallas !
Missing Pencil on tables
closes #1166
Also found several
pf-v5-m-
where the version should not be on the modifiers. This affected many items, such as not adding the blue left border to active menu items on the nav panelAside from removing the
-v5
frompf-m
modifiers, for the table I also removed theinline-edit
div as it doesn't appear we are doing inline edits and the styling for the inline-edit was basically just being removed manually by theenable
modifier.should also closes #1165