🐛 [main] Fix state management and validation of date pickers in migration wave modal #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
=======================================
Coverage 44.04% 44.04%
=======================================
Files 177 177
Lines 4493 4493
Branches 1007 1007
=======================================
Hits 1979 1979
Misses 2503 2503
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ve modal Signed-off-by: Mike Turley <[email protected]>
djzager
approved these changes
Jul 11, 2023
ibolton336
approved these changes
Jul 11, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #1110 forward to main.
I implemented this fix first on the release-0.2 branch in anticipation that it would be different for the PF4 and PF5 DatePicker components, since it is a high priority for the release. However, this is a pretty straightforward cherry-pick (with conflicts resolved) because the fix required turned out to be the same for PF5.