Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Archetype tags should be optional #1999

Closed
1 task done
rromannissen opened this issue Jul 5, 2024 · 2 comments · Fixed by #2047
Closed
1 task done

[BUG] Archetype tags should be optional #1999

rromannissen opened this issue Jul 5, 2024 · 2 comments · Fixed by #2047
Assignees
@rszwajko
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.1

Comments

@rromannissen
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5.0-alpha.2

Priority

Major

Current Behavior

Archetype tags are mandatory when creating an archetype:

Screenshot from 2024-07-05 10-09-36

They should be optional instead, as they are expected to be non required additional meta information to add to applications associated to the archetype. Criteria tags are the only ones that should be mandatory, as they define the relationship of an archetype with its associated applications.

Expected Behavior

Archetype tags should be optional.

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

Konveyor 0.5.0-alpha.2

Anything else?

No response
@rromannissen rromannissen added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 5, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 5, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 5, 2024
@dymurray dymurray added this to the v0.5.0 milestone Jul 8, 2024
@sjd78
Copy link
Member

sjd78 commented Jul 18, 2024

Note: The archetype POST endpoint supports creating an archetype with an empty tags prop.

@sjd78 sjd78 moved this from 🆕 New to 🔖 Ready in Planning Jul 18, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 18, 2024
@dymurray dymurray modified the milestones: v0.5.0, v0.5.1 Jul 18, 2024
@rszwajko rszwajko self-assigned this Aug 2, 2024
@rszwajko rszwajko moved this from 🔖 Ready to 🏗 In progress in Planning Aug 2, 2024
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Aug 2, 2024
@rszwajko
Allow creating archetype without tags
c13311f 
Resolves: konveyor#1999
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko mentioned this issue Aug 2, 2024
Merged
sjd78 pushed a commit that referenced this issue Aug 5, 2024
@rszwajko
🐛 Allow creating archetype without tags (#2047)
984543d 
Resolves: #1999

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Aug 5, 2024
github-actions bot pushed a commit that referenced this issue Aug 5, 2024
@rszwajko @web-flow
🐛 Allow creating archetype without tags (#2047)
bd4e347 
Resolves: #1999

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
@konveyor-ci-bot konveyor-ci-bot bot mentioned this issue Aug 5, 2024
Merged
sjd78 pushed a commit that referenced this issue Aug 5, 2024
@konveyor-ci-bot
🐛 [backport release-0.5] Allow creating archetype without tags (#2047) (
dbbc801 
#2050)

Resolves: #1999
Backport-of: #2047

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

🐛 Allow creating archetype without tags rszwajko/tackle2-ui
4 participants
@sjd78 @rromannissen @dymurray @rszwajko