Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all new tables to use the ActionsColumn component from PF5 #1318

Open
ibolton336 opened this issue Aug 29, 2023 · 4 comments
Open

Update all new tables to use the ActionsColumn component from PF5 #1318

ibolton336 opened this issue Aug 29, 2023 · 4 comments
Assignees
@mguetta1
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ibolton336
Copy link
Member

Example here: https://github.com/konveyor/tackle2-ui/pull/1314/files
@ibolton336 ibolton336 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 29, 2023
@ibolton336 ibolton336 mentioned this issue Aug 29, 2023
Merged
@avivtur avivtur self-assigned this Aug 29, 2023
@mturley
Copy link
Collaborator

mturley commented Sep 1, 2023

As part of doing this, we may want to also adopt the design pattern for Delete actions of putting them below a separator (item object with { isSeparator: true }) and use the isDanger property (makes the text red), as I'm doing in #1328. See example here: https://www.patternfly.org/components/menus/menu#danger-menu-item

@mguetta1 mguetta1 self-assigned this Apr 9, 2024
@mguetta1 mguetta1 mentioned this issue Apr 9, 2024
Merged
sjd78 added a commit that referenced this issue Apr 11, 2024
@mguetta1 @sjd78
✨ Set application delete as danger kebab menu item (#1829)
0c7cd84 
Part of #1318 

Resolves: https://issues.redhat.com/browse/MTA-2261

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 11, 2024
@mguetta1 @sjd78
✨ Set application delete as danger kebab menu item (konveyor#1829)
303d312 
Part of konveyor#1318

Resolves: https://issues.redhat.com/browse/MTA-2261

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
@sjd78 sjd78 mentioned this issue Apr 11, 2024
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 11, 2024
@mguetta1 @sjd78
✨ Set application delete as danger kebab menu item (konveyor#1829)
ab644f8 
Part of konveyor#1318

Resolves: https://issues.redhat.com/browse/MTA-2261

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 11, 2024
@mguetta1 @sjd78
✨ Set application delete as danger kebab menu item (konveyor#1829)
234de06 
Part of konveyor#1318

Resolves: https://issues.redhat.com/browse/MTA-2261

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 11, 2024
@mguetta1 @sjd78
✨ Set application delete as danger kebab menu item (konveyor#1829)
a683f4b 
Part of konveyor#1318

Resolves: https://issues.redhat.com/browse/MTA-2261

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit that referenced this issue Apr 12, 2024
@sjd78 @mguetta1
✨ Set application delete as danger kebab menu item (#1829) (#1840)
43cd5e9 
Part of #1318
Resolves: https://issues.redhat.com/browse/MTA-2261
Backport-of: #1829

Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Co-authored-by: Maayan Hadasi <[email protected]>
@mguetta1 mguetta1 mentioned this issue May 23, 2024
Merged
sjd78 added a commit that referenced this issue Jun 20, 2024
@mguetta1 @sjd78
✨ Update business services table to use ActionsColumn (#1921)
ffe06ee 
Related to #1318


![image](https://github.com/konveyor/tackle2-ui/assets/60384172/c8a51e2e-171d-4637-865b-2f784b213f89)

OR

![image](https://github.com/konveyor/tackle2-ui/assets/60384172/cff3f0bf-99dc-41f2-b578-6e119e3b4d9c)

---------

Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Scott Dickerson <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
@sjd78 sjd78 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 18, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 18, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 18, 2024
@sjd78 sjd78 mentioned this issue Aug 20, 2024
Merged
@sjd78
Copy link
Member

sjd78 commented Aug 30, 2024

This work is related to https://issues.redhat.com/browse/MTA-2261

sjd78 pushed a commit that referenced this issue Sep 10, 2024
@mguetta1
✨ Update stakeholders table to use ActionsColumn (#1923)
76c60f2 
Part of #1318

![image](https://github.com/konveyor/tackle2-ui/assets/60384172/48c3ec10-2aee-4adc-9652-9e72a4474b8e)

UI Tests PR: 1201

Signed-off-by: Maayan Hadasi <[email protected]>
github-actions bot pushed a commit that referenced this issue Sep 10, 2024
@mguetta1 @web-flow
✨ Update stakeholders table to use ActionsColumn (#1923)
e860ee2 
Part of #1318

![image](https://github.com/konveyor/tackle2-ui/assets/60384172/48c3ec10-2aee-4adc-9652-9e72a4474b8e)

UI Tests PR: 1201

Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
@konveyor-ci-bot konveyor-ci-bot bot mentioned this issue Sep 10, 2024
Merged
sjd78 pushed a commit that referenced this issue Sep 10, 2024
@konveyor-ci-bot
✨ Update stakeholders table to use ActionsColumn (#1923) (#2083)
34fc937 
Part of #1318

![image](https://github.com/konveyor/tackle2-ui/assets/60384172/48c3ec10-2aee-4adc-9652-9e72a4474b8e)

Backport-of: #1923
Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
@mguetta1 mguetta1 mentioned this issue Sep 16, 2024
Merged
@HadasahR HadasahR mentioned this issue Sep 24, 2024
Closed
rszwajko pushed a commit that referenced this issue Sep 26, 2024
@MiriSafra
✨ Update stakeholder groups table to use ActionsColumn (#2095)
c04bb35 
Addition ActionsColumn to  Stakeholder groups table
Relates to #1318
UI tests PR: 1222

Signed-off-by: MiriSafra <[email protected]>
@mguetta1 mguetta1 mentioned this issue Sep 29, 2024
Merged
@DvoraShechter1 DvoraShechter1 mentioned this issue Sep 29, 2024
Merged
sjd78 added a commit that referenced this issue Oct 4, 2024
@Shevijacobson @rszwajko @sjd78
✨ Add edit icon with ActionColumns property in the Archetypes table (#…
7d288bd 
…2098)

**Changes Made:**

- Removed the edit action from the ActionsColumn.

- Added a dedicated edit icon outside the ActionsColumn, providing a
clearer and more focused user interface.

Part of #1318 

Before the change:

![Screenshot from 2024-09-29
10-24-26](https://github.com/user-attachments/assets/b0c23db6-a913-4361-9435-6c4ecc296643)

After the change:

![Screenshot from 2024-09-29
10-28-03](https://github.com/user-attachments/assets/175e9d03-f1cd-48b9-b523-bb23b95d71be)

---------

Signed-off-by: Shevijacobson <[email protected]>
Co-authored-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
@mguetta1 mguetta1 mentioned this issue Oct 8, 2024
Merged
sarinailinger pushed a commit to sarinailinger/tackle2-ui that referenced this issue Oct 30, 2024
@MiriSafra @sarinailinger
✨ Update stakeholder groups table to use ActionsColumn (konveyor#2095)
4c4d5b9 
Addition ActionsColumn to  Stakeholder groups table
Relates to konveyor#1318
UI tests PR: 1222

Signed-off-by: MiriSafra <[email protected]>
sjd78 pushed a commit that referenced this issue Nov 4, 2024
@DvoraShechter1
✨ Add ActionsColumn to Job Functions table (#2101)
7ffaf98 
Update the Actions column in the Job Functions table to use PatternFly 5
controls, replacing the PatternFly 4 controls.

Relates to #1318

---------

Signed-off-by: DvoraShechter1 <[email protected]>
mguetta1 added a commit that referenced this issue Jan 22, 2025
@TalyaNaima @sjd78 @mguetta1
✨ tags table change button styles (#2119)
ea8405e 
Changing the style of the edit & delete buttons in tags table (including
the tags category)

Part of #1318 
UI tests PR: 1237

Signed-off-by: TalyaNeima <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Co-authored-by: Maayan Hadasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mguetta1 mguetta1

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mturley @sjd78 @ibolton336 @mguetta1 @avivtur