Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components, hooks and utilities file names and folders to be consistent #1249

Closed
gildub opened this issue Aug 4, 2023 · 0 comments
Closed

Components, hooks and utilities file names and folders to be consistent #1249

gildub opened this issue Aug 4, 2023 · 0 comments

Comments

@gildub
Copy link
Contributor

gildub commented Aug 4, 2023 •
edited
Loading

As the applications grows we need to keep structural complexity at bay to avoid confusion and slowing us down unnecessarily.

We currently have :

  • app/shared/components
  • app/shared/containers
  • app/shared/hooks
  • app/common containing components and hook
  • app/components

We can reorganize using intermediate folder structure having:

  • app/components
  • app/hooks
  • app/utils
@gildub gildub mentioned this issue Aug 4, 2023
Merged
@gildub gildub changed the title Components, hooks and utilities file names and folders to be more consistent Components, hooks and utilities file names and folders to be consistent Aug 4, 2023
ibolton336 pushed a commit that referenced this issue Aug 8, 2023
@gildub
✨ Regroup shared and common components along naming standardization (#…
e47565e 
…1248)

- `app/components`: regroups `app/shared/components`,
`app/common/components` and `app/shared/containers`
- `app/hooks`: regroups `app/shared/hooks`
- `app/utils/`: Now includes `rules-utils from `app/common/CustomRules/`

When not necessary the index.ts file has been removed.
Renamed component files using CamelCase.

See #1249

---------

Signed-off-by: Gilles Dubreuil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gildub @ibolton336