Skip to content

Commit

Permalink
Move task group creation to wizard onMove past the first step
Browse files Browse the repository at this point in the history
Signed-off-by: ibolton336 <[email protected]>
  • Loading branch information
ibolton336 committed Aug 8, 2023
1 parent c777e34 commit bfd1bd3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,6 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
const [stepIdReached, setStepIdReached] = React.useState(1);
const isMutating = useIsMutating();

React.useEffect(() => {
if (!currentTaskgroup) {
createTaskgroup(defaultTaskgroup);
}
}, []);

const onCreateTaskgroupSuccess = (data: Taskgroup) => {
setCurrentTaskgroup(data);
};
Expand Down Expand Up @@ -293,6 +287,7 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({

submitTaskgroup(taskgroup);
}
setCurrentTaskgroup(null);
reset();
onClose();
};
Expand All @@ -302,12 +297,19 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
{ prevId, prevName }
) => {
if (id && stepIdReached < (id as number)) setStepIdReached(id as number);
if (id === 2) {
if (!currentTaskgroup) {
createTaskgroup(defaultTaskgroup);
}
}
};

const handleClose = () => {
reset();
if (currentTaskgroup && currentTaskgroup.id)
if (currentTaskgroup && currentTaskgroup.id) {
deleteTaskgroup(currentTaskgroup.id);
setCurrentTaskgroup(null);
}
onClose();
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ export const ApplicationsTableAnalyze: React.FC = () => {
const { t } = useTranslation();
const { pushNotification } = React.useContext(NotificationsContext);

const [isAnalyzeModalOpen, setAnalyzeModalOpen] = React.useState(false);
const [createUpdateModalState, setCreateUpdateModalState] = React.useState<
Application | Application[] | null
>(null);
const isWizardOpen = createUpdateModalState !== null;

const [saveApplicationsModalState, setSaveApplicationsModalState] =
React.useState<"create" | Application | null>(null);
Expand Down Expand Up @@ -553,7 +556,7 @@ export const ApplicationsTableAnalyze: React.FC = () => {
aria-label="Analyze Application"
variant={ButtonVariant.primary}
onClick={() => {
setAnalyzeModalOpen(true);
setCreateUpdateModalState(selectedRows);
}}
isDisabled={
selectedRows.length < 1 || !isAnalyzingAllowed()
Expand Down Expand Up @@ -613,9 +616,9 @@ export const ApplicationsTableAnalyze: React.FC = () => {
</Modal>{" "}
<AnalysisWizard
applications={selectedRows}
isOpen={isAnalyzeModalOpen}
isOpen={isWizardOpen}
onClose={() => {
setAnalyzeModalOpen(false);
setCreateUpdateModalState(null);
}}
/>
<Modal
Expand Down

0 comments on commit bfd1bd3

Please sign in to comment.