PR updates

konveyor · Nov 15, 2023 · a4d34b2 · a4d34b2
1 parent 60bb44c
commit a4d34b2
Showing 1 changed file with 22 additions and 11 deletions.
diff --git a/client/src/app/pages/dependencies/dependency-apps-table.tsx b/client/src/app/pages/dependencies/dependency-apps-table.tsx
@@ -1,6 +1,11 @@
 import * as React from "react";
 import { useTranslation } from "react-i18next";
-import { Toolbar, ToolbarContent, ToolbarItem } from "@patternfly/react-core";
+import {
+  TextContent,
+  Toolbar,
+  ToolbarContent,
+  ToolbarItem,
+} from "@patternfly/react-core";
 import { Table, Tbody, Td, Th, Thead, Tr } from "@patternfly/react-table";
 import spacing from "@patternfly/react-styles/css/utilities/Spacing/spacing";
 import { useSelectionState } from "@migtools/lib-ui";
@@ -140,15 +145,6 @@ export const DependencyAppsTable: React.FC<IDependencyAppsTableProps> = ({
     },
   } = tableControls;
 
-  const getManagementValue = (appDependency: AnalysisAppDependency) => {
-    const hasJavaLabel = appDependency.dependency.labels.some((label) => {
-      const labelValue = getParsedLabel(label).labelValue;
-      return labelValue === "java";
-    });
-    const isJavaFile = dependency.name.endsWith(".jar");
-    return hasJavaLabel && isJavaFile;
-  };
-
   return (
     <>
       <Toolbar {...toolbarProps} className={spacing.mtSm}>
@@ -213,7 +209,7 @@ export const DependencyAppsTable: React.FC<IDependencyAppsTableProps> = ({
                     modifier="nowrap"
                     {...getTdProps({ columnKey: "management" })}
                   >
-                    {getManagementValue(appDependency) ? "Managed" : "Embedded"}
+                    <DependencyManagementColumn appDependency={appDependency} />
                   </Td>
                   <Td
                     width={20}
@@ -239,3 +235,18 @@ export const DependencyAppsTable: React.FC<IDependencyAppsTableProps> = ({
     </>
   );
 };
+
+const DependencyManagementColumn = ({
+  appDependency,
+}: {
+  appDependency: AnalysisAppDependency;
+}) => {
+  const hasJavaLabel = appDependency.dependency.labels.some((label) => {
+    const labelValue = getParsedLabel(label).labelValue;
+    return labelValue === "java";
+  });
+  const isJavaFile = appDependency.dependency.name.endsWith(".jar");
+  const isJavaDependency = hasJavaLabel && isJavaFile;
+
+  return <TextContent>{isJavaDependency ? "Managed" : "Embedded"}</TextContent>;
+};