Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix javaee-pom-to-quarkus-00050 rule #240

Merged
merged 1 commit into from
Jan 31, 2025
Merged

🐛 fix javaee-pom-to-quarkus-00050 rule #240

merged 1 commit into from
Jan 31, 2025

Conversation

abrugaro
Copy link
Contributor

@abrugaro abrugaro commented Jan 29, 2025 •
edited
Loading

In this rule, the native.image.path property may appear directly under configuration inside the plugin instead of inside the execution tag.

@abrugaro
fix javaee-pom-to-quarkus-00050 rule
4c6b32a 
Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro force-pushed the fix-javaee-pom-to-quarkus-00050-rule branch from 91f765b to 4c6b32a Compare January 29, 2025 10:12
@jmle jmle self-requested a review January 29, 2025 10:20
@abrugaro abrugaro changed the title fix javaee-pom-to-quarkus-00050 rule 🐛 fix javaee-pom-to-quarkus-00050 rule Jan 30, 2025
jmle
jmle approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👎

@jmle jmle merged commit 76a9e67 into konveyor:main Jan 31, 2025
6 checks passed
@abrugaro abrugaro deleted the fix-javaee-pom-to-quarkus-00050-rule branch February 3, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmle jmle jmle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrugaro @jmle