-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private key transfer #1090
Private key transfer #1090
Conversation
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
Although it's a bit tricky because the actual work is done in NumberValidation, meaning that if it fails, form data in ImportDeviceActivity will be lost. So next step would be to retrieve the private key from ImportDeviceActivity and pass it on via activity result to NumberValidation. Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
@abika I finished the implementation and I did some modifications to your code too. Particularly, I had to also receive the public key along with the private key because the public key contains the signature that is needed to actually login. The public key is not uploaded though, it is automatically returned by the server along with the private key (since the server has a copy). Needless to say, the new code still requires massive testing. I might publish it on the Google Play alpha channel. |
It seems this #122 is closed by this. |
You're right, thanks! |
Thanks for your work Daniele! I will look into it and implement the key transfer on the Desktop-Client side. Seems like I already started some of it two years ago to make the integration in the import wizard easier - although I can't remember doing so.) |
Don't worry, no rush. |
I've updated the specs page with the protocol. The The private key will be encrypted so you should ask for the passphrase before trying to import it. |
Use the session channel to deliver the private key safely to another device.
Server: kontalk/tigase-extension#85