fix gboard issue #1087
Merged
fix gboard issue #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conversion is now triggered by space after smiley
|
Thanks @115ek, this will do just fine! |
|
@115ek Great work. Thank you!
I'm glad to see there are devs who help Kontalk to grow up.
Now you can catch the next issue.
There are enough open important issues ;-)
I will work hard as beta tester to find issues.
|
|
I'm not an expert but it's really great to contribute even small things to Kontalk. |
|
If you'd like to continue on this road, there are many things to be done. I've recently begun to mark issues with labels help wanted and good first issue. The latter are easier to get on so you can get more into the architecture of the Kontalk app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conversion is now triggered by space after smiley
This fixes the google keyboard problem: every ASCII smiley needs a following space to confirm the conversion.
Now
"ASCII_smiley" + "space" is converted into "emoji" + "space".Is that okay or should we do it that way:
"ASCII_smiley" + "space" is converted into "emoji"?