Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Location sharing #1027

Merged
merged 45 commits into from
Sep 2, 2017
Merged

[WIP] Location sharing #1027

merged 45 commits into from
Sep 2, 2017

Conversation

sw1ftc0d3r
Copy link
Member

@sw1ftc0d3r sw1ftc0d3r commented Jun 28, 2017

Absorbing #51.

Things to be addressed:

  • red pin is not correctly positioned when zooming in or out or rotating the map set the anchor point
  • common classes and derivates for fragments
  • map/satellite menu items should be radio items
  • message type in details should be "Location message"
  • message snippet in conversations view shows the Google Maps URL (should show "Location")
  • fix up some XMPP related classes (e.g. move UserLocation to client-common-java)
  • test orientation change/pause-resume cycle (especially map/satellite checked state consistency)
  • rename maps settings section to location
  • maps URL generation currently hard-coded into PositionManager
  • check fallback behaviour to OSM when Google is not present on the device (try emulator)
  • Can't find method 'requestRouteToHost(int,int)' in class android.net.ConnectivityManager targeting SDK version 26 osmdroid/osmdroid#633 (safe since getRouteToPathExists is never used)
  • is OSM satellite available? If not, do not display choice in menu

Optional:

  • sharing a location message should give the opportunity to actually share the text data instead of the location (subject to opinions actually) converted to "go to maps" button for now; sharing message disabled
  • common classes and derivates for send fragments (moved in Location sharing (part 2) #1056)
  • use different pin icons for OSM and Google Maps (moved in Location sharing (part 2) #1056)
  • map/satellite state consistency after orientation change (moved in Location sharing (part 2) #1056)

Andrea Cappelli and others added 20 commits May 18, 2017 17:22
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
@daniele-athome daniele-athome self-requested a review June 28, 2017 12:29
@daniele-athome daniele-athome self-assigned this Jun 28, 2017
@daniele-athome daniele-athome added the enhancement New feature or request label Jun 28, 2017
@daniele-athome daniele-athome added this to the 4.0.5 milestone Jun 28, 2017
@daniele-athome daniele-athome changed the title Feature/position [WIP] Location sharing Jun 28, 2017
daniele-athome and others added 4 commits June 29, 2017 22:01
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
Signed-off-by: Andrea Cappelli <[email protected]>
@daniele-athome daniele-athome modified the milestones: 4.0.5, 4.1.0 Jul 10, 2017
Apparently, ConnectivityManager.requestRouteToHost was *removed* from
the source code in API level 26. This might cause problems on Android O,
and adding a dontwarn to ProGuard isn't really the ideal solution.

Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
And also be safe if no location provider can be found on the system.

Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
@daniele-athome daniele-athome mentioned this pull request Sep 2, 2017
4 tasks
@daniele-athome daniele-athome merged commit e61cf6f into master Sep 2, 2017
@daniele-athome daniele-athome deleted the feature/position branch September 2, 2017 12:55
@daniele-athome daniele-athome restored the feature/position branch September 2, 2017 12:55
@daniele-athome daniele-athome deleted the feature/position branch September 2, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants