Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove subscription flow interaction for local users #1294

Closed
daniele-athome opened this issue Mar 31, 2020 · 1 comment
Closed

Remove subscription flow interaction for local users #1294

daniele-athome opened this issue Mar 31, 2020 · 1 comment
Assignees
@daniele-athome
Labels
enhancement New feature or request
Milestone
4.4.0

Comments

@daniele-athome
Copy link
Member

daniele-athome commented Mar 31, 2020 •
edited
Loading

As a first step for #1255, begin by autoaccepting invitations from local (as in the same network) users. Subscription flow will be activated only for users outside of the network the client is connected to.

We still don't have a way to recognize if a JID is local to the network. The only way to do that would be to look at the server list. So we should store it in account userdata. Also think about the internal server list (and the cached one) and its purpose after this: which one would be used? The one in account userdata or the one in cache/internal?
@daniele-athome daniele-athome added the enhancement New feature or request label Mar 31, 2020
@daniele-athome daniele-athome added this to the Next milestone Mar 31, 2020
daniele-athome added a commit that referenced this issue Apr 5, 2020
@daniele-athome
Introducing class MyAccount
33d0119 
Avoid use of class Authenticator throughout the app. Also a good
preparation step for #1294 and #65

Signed-off-by: Daniele Ricci <[email protected]>
@daniele-athome daniele-athome self-assigned this Apr 13, 2020
daniele-athome added a commit that referenced this issue Apr 13, 2020
@daniele-athome
Write server list information in account user data
27dbb1c 
Related to #1294 and one step forward towards #65

Signed-off-by: Daniele Ricci <[email protected]>
daniele-athome added a commit that referenced this issue Apr 13, 2020
@daniele-athome
We can now check for network JIDs (#1294)
8277029 
Signed-off-by: Daniele Ricci <[email protected]>
daniele-athome added a commit that referenced this issue Apr 13, 2020
@daniele-athome
Automatically accept chat invitations from network JIDs (#1294)
b538302 
Signed-off-by: Daniele Ricci <[email protected]>
@daniele-athome
Copy link
Member Author

Finally closed in b538302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniele-athome daniele-athome

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
1 participant
@daniele-athome