Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stanza async reply instead of listener #1093

Closed
3 tasks done
daniele-athome opened this issue Nov 8, 2017 · 0 comments
Closed
3 tasks done

Use stanza async reply instead of listener #1093

daniele-athome opened this issue Nov 8, 2017 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@daniele-athome
Copy link
Member

daniele-athome commented Nov 8, 2017

In some cases (e.g. last activity request, but all IQs in general) we need to process the reply, not wait with a listener. This is especially useful for handling error packets which are not captured by extension listeners.
This should also solve the big wait during contacts sync when requesting keys to non-Kontalk or to blocked users (because the error reply is not processed in any way).

This can (and should) be considered a bug because it causes a few reliability issues.

Strictly speaking, we'll need to convert:

  • last activity
  • public key request
  • roster match (maybe)

Also there are existing calls to conn.sendIqBlaBla. Unify them into the new method.

@daniele-athome daniele-athome added the bug Something isn't working label Nov 8, 2017
@daniele-athome daniele-athome self-assigned this Nov 8, 2017
daniele-athome added a commit that referenced this issue Nov 8, 2017
@daniele-athome daniele-athome added this to the Next milestone Nov 14, 2017
daniele-athome added a commit that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant