aws physical cluster adjustment #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarededwards
changed the title
D-B-Hawk
previously approved these changes
Jan 30, 2024
D-B-Hawk
approved these changes
Jan 30, 2024
mrsimonemms
added a commit
that referenced
this pull request
Jul 18, 2024
The previous #288 installation doesn't seem to work because there's no `secret` specified in the `credentials.NewStaticCredentialsProvider` call. I don't fully understand the reasosn why this was changed because the envvar `AWS_WEB_IDENTITY_TOKEN_FILE` is one of the documented ways of authenticating - https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/#specifying-credentials
mrsimonemms
added a commit
that referenced
this pull request
Jul 18, 2024
The previous #288 installation doesn't seem to work because there's no `secret` specified in the `credentials.NewStaticCredentialsProvider` call. I don't fully understand the reasosn why this was changed because the envvar `AWS_WEB_IDENTITY_TOKEN_FILE` is one of the documented ways of authenticating - https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/#specifying-credentials
mrsimonemms
added a commit
that referenced
this pull request
Jul 22, 2024
The previous #288 installation doesn't seem to work because there's no `secret` specified in the `credentials.NewStaticCredentialsProvider` call. I don't fully understand the reasosn why this was changed because the envvar `AWS_WEB_IDENTITY_TOKEN_FILE` is one of the documented ways of authenticating - https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/#specifying-credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.