fix: Small renaming and corrections after review

konnectors · Jul 26, 2024 · e0f0eee · e0f0eee
1 parent df6ba20
commit e0f0eee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/packages/cozy-clisk/src/contentscript/ContentScript.js b/packages/cozy-clisk/src/contentscript/ContentScript.js
@@ -100,8 +100,6 @@ export default class ContentScript {
         suffixFn: args => args?.[0]
       }
     )
-    this.shouldFullSync = wrapTimerDebug(this, 'shouldFullSync')
-
     if (options.requestInterceptor) {
       this.requestInterceptor = options.requestInterceptor
       this.requestInterceptor.setLogger(this.log.bind(this))
@@ -137,8 +135,7 @@ export default class ContentScript {
       'getDebugData',
       'getCliskVersion',
       'checkForElement',
-      'evaluate',
-      'shouldFullSync'
+      'evaluate'
     ]
 
     if (options.additionalExposedMethodsNames) {
@@ -939,10 +936,10 @@ export default class ContentScript {
     this.onlyIn(PILOT_TYPE, 'shouldFullSync')
     const { trigger, flags } = options
     let forceFullSync = false
-    let userFullSync = false
+    let flagFullSync = false
     if (flags['clisk.force-full-sync'] === true) {
       this.log('info', 'User forces full sync')
-      userFullSync = true
+      flagFullSync = true
     }
     const isFirstJob =
       !trigger.current_state?.last_failure &&
@@ -959,7 +956,7 @@ export default class ContentScript {
     }
     this.log('debug', `distanceInDays: ${distanceInDays}`)
     if (
-      userFullSync ||
+      flagFullSync ||
       !hasLastExecution ||
       isLastJobError ||
       distanceInDays >= 30

diff --git a/packages/cozy-clisk/src/contentscript/ContentScript.spec.js b/packages/cozy-clisk/src/contentscript/ContentScript.spec.js
@@ -200,7 +200,7 @@ describe('ContentScript', () => {
     })
   })
   describe('shouldFullSync', () => {
-    it('should force full sync => Flag', async () => {
+    it('should force full sync if forceFullSync flag is activated', async () => {
       const contentScript = new ContentScript()
       contentScript.contentScriptType = PILOT_TYPE
 
@@ -222,7 +222,7 @@ describe('ContentScript', () => {
         distanceInDays: 0
       })
     })
-    it('should force full sync => First execution', async () => {
+    it('should force full sync if it is the first execution', async () => {
       const contentScript = new ContentScript()
       contentScript.contentScriptType = PILOT_TYPE
 
@@ -240,7 +240,7 @@ describe('ContentScript', () => {
         distanceInDays: 0
       })
     })
-    it('should force full sync => Last execution failed', async () => {
+    it('should force full sync if the last execution failed', async () => {
       const contentScript = new ContentScript()
       contentScript.contentScriptType = PILOT_TYPE
 
@@ -262,7 +262,7 @@ describe('ContentScript', () => {
         distanceInDays: 0
       })
     })
-    it('should not force full sync', async () => {
+    it('should not force full sync in nominal case', async () => {
       const contentScript = new ContentScript()
       contentScript.contentScriptType = PILOT_TYPE