Feat/creds interception with events #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redo the creds interception by using workerEvents instead of findAndSendCredentials method.
It also enhance the identity fetching by using the sessionStorage instead scraping, avoiding navigation making a quicker execution.
I also notice the autoLogin was not working anymore. The website added a check on the isTrusted property of the click event on the loginButton, so I replace the autoLogin with an autoFill function as it is done for other konnectors without autoLogin possibilities.
I tried de "iFrame trick" we use for Bouygues, but it is not possible here as the loginForm is not in the iFrame, so we need to load the formPage to get the iFram src but when reaching the captchaUrl, the needed token we can get is not the awaited one anymore, because we need to get back to the loginForm to be able to use it, and so on, it's a catch-22 situation.