Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/91 - BYO logger #93

Merged
merged 62 commits into from
Feb 2, 2019
Merged

Issues/91 - BYO logger #93

merged 62 commits into from
Feb 2, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 1, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • bring your own logger
  • TODO: add tests for logger

Why(Why did you change it?)

References:

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #93 into master will decrease coverage by 0.28%.
The diff coverage is 69.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   85.23%   84.95%   -0.29%     
==========================================
  Files          12       12              
  Lines         901      924      +23     
==========================================
+ Hits          768      785      +17     
- Misses        133      139       +6
Impacted Files Coverage Δ
naz/throttle.py 91.83% <100%> (ø) ⬆️
naz/ratelimiter.py 96.96% <100%> (ø) ⬆️
naz/hooks.py 81.25% <100%> (ø) ⬆️
cli/cli.py 68.06% <53.84%> (-2.02%) ⬇️
naz/client.py 81.85% <59.15%> (-0.67%) ⬇️
naz/logger.py 93.93% <93.33%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c091f...324e45c. Read the comment docs.

@komuw komuw merged commit dbc7d0f into master Feb 2, 2019
@komuw komuw deleted the issues/91 branch February 2, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

naz client should not have an inbuilt logger
2 participants