Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to DEBUG env value #18

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add quotes to DEBUG env value #18

merged 1 commit into from
Jul 5, 2023

Conversation

bobh66
Copy link
Contributor

@bobh66 bobh66 commented Jul 5, 2023

Add quotes to the value for DEBUG so that the 1 gets handled as a string and not a number.

Fixes #17

@undera
Copy link
Collaborator

undera commented Jul 5, 2023

Oops, sorry, missed this PR :) I already did the same change.

@undera undera merged commit 757245e into komodorio:main Jul 5, 2023
@undera
Copy link
Collaborator

undera commented Jul 5, 2023

@bobh66 Do you want me to do a new release with this change, or it's ok to accumulate more changes?

@bobh66
Copy link
Contributor Author

bobh66 commented Jul 5, 2023

@bobh66 Do you want me to do a new release with this change, or it's ok to accumulate more changes?

Accumulating more changes is fine. I have a local copy with the fixes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting debug in values.yaml causes error on deployment
2 participants