-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove include for nonexistent directory #581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sethrj
@sethrj Are you a Sandian ? Then you can follow the spot-check process, if not one of us will have to do the spot check ? |
@srajama1 I interned at SNL 15 years ago 😆 but no, I'm at ORNL. Could one of you please take care of it? |
@sethrj Thanks ! We will run the spot-check. |
These changes were made against kokkos-kernels master branch, but it in develop with the updated CMake it looks like there is still a line like this: @sethrj would you like to update your PR (and direct merge into develop) or would you like us to issue a new PR? |
@ndellingwood I'll update the PR, I clearly didn't follow the rabbit hole deep enough (we use a mirror of trilinos, which uses a snapshot of kokkos master, which ....) |
@ndellingwood OK should be good to go now. |
Thanks @sethrj , running spot-check tests now. Since you're building through Trilinos we'll patch this into Trilinos as well. |
Spot-check passes on kokkos-dev-2 (no surprise), thanks for the contribution @sethrj !
|
patch matching kokkos/kokkos-kernels#581 provided by @sethrj
@sethrj I put in the matching patch to trilinos in PR trilinos/Trilinos#6757 |
When building a Fortran code that links against Kokkos as part of the same TriBITS project, the compiler complains because the Kokkos logic references a nonexistent directory. This PR simply removes the offending include command.
See trilinos/Trilinos#6669