Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for block jacobi and eigen solver #560

Closed
wants to merge 13 commits into from

Conversation

kyungjoo-kim
Copy link
Contributor

This provides an example code for block jacobi (small block size about O(10)). As this goes into perf test, it is probably safe to be merged. I tested on blake (intel) and tried to test on white but the test bed is full now. I will update the PR once I can greb a node from white.

Kyungjoo Kim and others added 5 commits October 9, 2019 17:20
  when kokkos complex is used inside of a vector loop, somehow intel compiler
  produces wrong results. this might be because the vectorization does not well
  handle user-defined type i.e., kokkos complex.
@kyungjoo-kim kyungjoo-kim self-assigned this Jan 9, 2020
@kyungjoo-kim
Copy link
Contributor Author

@ndellingwood I checked this PR for blake and white but I somehow cannot run the cm_test_all_sandia script. When you have time, would you help me run the script ?

@ndellingwood
Copy link
Contributor

Which queue are you using on White? If you're using rhel7G, make sure to change the arch code and bsub to the queue before launching the script. The script options should be the same as with test_all_sandia. I've used the script on white successfully, you may need to specify paths for kokkos and kokkos-kernels, and also make sure you are using kokkos' develop branch.

@kyungjoo-kim
Copy link
Contributor Author

@ndellingwood would you approve this PR and include in the promotion branch ?

[kyukim @kokkos-dev-2] test-all > ../../../kyukim/scripts/cm_test_all_sandia cuda/10.0 cuda/10.1 clang/8.0 gcc/9.1 intel/19.0.5 clang/7.0.1
Running on machine: kokkos-dev-2
Repository Status:  b325e84f3b94470a1e71fdbd38f20eb8f62813ee KokkosBatched - fix a bug on GPUs. checked on white.
...
...
#######################################################
PASSED TESTS
#######################################################
clang-7.0.1-Pthread-release build_time=41 run_time=78
clang-7.0.1-Pthread_Serial-release build_time=57 run_time=146
clang-7.0.1-Serial-release build_time=40 run_time=65
clang-8.0-Cuda_OpenMP-release build_time=125 run_time=158
clang-8.0-Cuda_Serial-release build_time=124 run_time=186
cuda-10.0-Cuda_Pthread-release build_time=157 run_time=168
cuda-10.0-Cuda_Serial-release build_time=162 run_time=179
cuda-10.1-Cuda_Pthread-release build_time=172 run_time=173
cuda-10.1-Cuda_Serial-release build_time=182 run_time=169
gcc-9.1-OpenMP-release build_time=53 run_time=46
gcc-9.1-Serial-release build_time=46 run_time=63
intel-19.0.5-OpenMP-release build_time=133 run_time=43
intel-19.0.5-OpenMP_Serial-release build_time=160 run_time=118
intel-19.0.5-Pthread-release build_time=158 run_time=55
intel-19.0.5-Pthread_Serial-release build_time=184 run_time=136
intel-19.0.5-Serial-release build_time=153 run_time=55

@kyungjoo-kim kyungjoo-kim changed the title Example for block jacobi Example for block jacobi and eigen solver Jan 14, 2020
@ndellingwood
Copy link
Contributor

@kyungjoo-kim can you squash commits to a single commit? That will make this much easier to cherry-pick to the release-candidate-3.0 branch if we get this in with the promotion.

@kyungjoo-kim
Copy link
Contributor Author

@ndellingwood I would like to squash the commits but somehow I can only see noop from git rebase. Would you help me squash the commits when you are available ?

@ndellingwood
Copy link
Contributor

@kyungjoo-kim can you rerun spot-checks on this? We can get this merged into develop once passing.

@kyungjoo-kim
Copy link
Contributor Author

I am going to hold this a while.

@ndellingwood
Copy link
Contributor

@kyungjoo-kim are you wanting this for 3.1, or is this still WIP?

@kyungjoo-kim
Copy link
Contributor Author

I don' think that this is urgent.

@srajama1
Copy link
Contributor

I am surprised we didn't push this. Is this because of squashing. If there is something wrong with the process that makes it harder for simple commits like this, we should fix the process.

@ndellingwood
Copy link
Contributor

Squashing commits isn't necessary, I requested before since this was right near the end of integration testing and wanted to be able to back out the changes easily in case issues occurred. If that was a barrier please disregard.

@kyungjoo-kim kyungjoo-kim deleted the develop branch February 9, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants