-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for block jacobi and eigen solver #560
Conversation
when kokkos complex is used inside of a vector loop, somehow intel compiler produces wrong results. this might be because the vectorization does not well handle user-defined type i.e., kokkos complex.
checked on white.
@ndellingwood I checked this PR for blake and white but I somehow cannot run the cm_test_all_sandia script. When you have time, would you help me run the script ? |
Which queue are you using on White? If you're using rhel7G, make sure to change the arch code and bsub to the queue before launching the script. The script options should be the same as with test_all_sandia. I've used the script on white successfully, you may need to specify paths for kokkos and kokkos-kernels, and also make sure you are using kokkos' develop branch. |
@ndellingwood would you approve this PR and include in the promotion branch ?
|
@kyungjoo-kim can you squash commits to a single commit? That will make this much easier to cherry-pick to the release-candidate-3.0 branch if we get this in with the promotion. |
@ndellingwood I would like to squash the commits but somehow I can only see noop from git rebase. Would you help me squash the commits when you are available ? |
@kyungjoo-kim can you rerun spot-checks on this? We can get this merged into develop once passing. |
I am going to hold this a while. |
@kyungjoo-kim are you wanting this for 3.1, or is this still WIP? |
I don' think that this is urgent. |
I am surprised we didn't push this. Is this because of squashing. If there is something wrong with the process that makes it harder for simple commits like this, we should fix the process. |
Squashing commits isn't necessary, I requested before since this was right near the end of integration testing and wanted to be able to back out the changes easily in case issues occurred. If that was a barrier please disregard. |
This provides an example code for block jacobi (small block size about O(10)). As this goes into perf test, it is probably safe to be merged. I tested on blake (intel) and tried to test on white but the test bed is full now. I will update the PR once I can greb a node from white.