#845: Return unknown previous block when the parent node is not final… #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgerbino
requested changes
Dec 3, 2024
| @@ -322,6 +322,8 @@ apply_block_result controller_impl::apply_block( const protocol::block& block, c | |||
| KOINOS_ASSERT( block_id == root->id(), unknown_previous_block_exception, "unknown previous block" ); | |||
| return {}; // Block is current LIB | |||
| } | |||
| else | |||
| KOINOS_ASSERT( parent_node->is_finalized(), unknown_previous_block_exception, "unknown previous block" ); | |||
There was a problem hiding this comment.
If the if uses braces we should use braces in the else
There was a problem hiding this comment.
Also, it appears there's an integration failure
There was a problem hiding this comment.
It fails the integration test because the branch was based on a commit prior to the nonce changes. I built the image manually and pushed it for testing p2p without all of the nonce code.
I can merge master in to the branch to pass integration tests, but then I cannot test it on its own with p2p.
sgerbino
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ized
Resolves #845
Brief description
Returns
unknown_previous_blockerror when the parent node is not finalized. The prevents a deadlock when the parent node is trying to finalize and the child node is waiting on the parent node to finalize to create a state node.Branch is not passing CI because it is not based on
latestand therefore fails thepending_nonceintegration test. This is expected. The branch is good otherwise and is running in dev.Checklist
Demonstration