Fix bug in nchar when dealing with factors

kohske · Nov 11, 2009 · 799f6e3 · 799f6e3
1 parent 673c9f3
commit 799f6e3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -0,0 +1,4 @@
+stringr 0.2
+===========
+
+ * str_length now returns correct results when used with factors
diff --git a/R/basics.r b/R/basics.r
@@ -9,6 +9,7 @@
 #' str_length(letters)
 #' str_length(c("i", "like", "programming", NA))
 str_length <- function(string) {
+  string <- as.character(string)
   nc <- nchar(string)
   is.na(nc) <- is.na(string)
   nc

diff --git a/tests/test-length.r b/tests/test-length.r
@@ -6,4 +6,8 @@ context("String length")
 test_that("length of missing string is missing", {
   expect_that(str_length(NA), equals(NA_integer_))
   expect_that(str_length("NA"), equals(2))
+})
+
+test_that("works with factors", {
+  expect_that(str_length(factor("abc")), equals(3))
 })