Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields are shown with grey background in presentation/view mode #816

Closed
kossebau opened this issue Sep 17, 2014 · 4 comments · Fixed by #819
Closed

Fields are shown with grey background in presentation/view mode #816

kossebau opened this issue Sep 17, 2014 · 4 comments · Fixed by #819

Comments

@kossebau
Copy link
Contributor

WebODF tag 0.5.3

Fields in slides and documents are shown with grey background in non-editing mode, which seems not right to me. It should be controllable in some way, and by default turned off.

@peitschie
Copy link
Contributor

Discussed proposal on IRC was to extract a gui.OdfFieldView and move the field highlighting code out to that. This would allow interested parties to construct the view in order to enable field highlighting.

Any counter-proposals? :-)

@adityab
Copy link
Member

adityab commented Sep 17, 2014

gui.OdfFieldView makes sense.

Behavior-wise, I would prefer a grey background only on hovering over fields - as is done in the user fields invoice demo - and that too only in editing mode. LO's implementation looks ugly.

@kossebau
Copy link
Contributor Author

So the idea would be that fields by default do not get any special rendering and their content is simply rendered as if it was normal text. Only those who are interested in special rendering would add another rendering view for them, like done with annotations, but not exactly. Do I get that correctly?
This also would allow alternative views/renderers, to cover UX/UI as @adityab proposed (where I would rather favour LO's, at least for consistency).

@peitschie
Copy link
Contributor

@kossebau yep. That is an accurate summary. My default would be to preserve LO behaviour... but if it's easy I'd be willing to add a feature flag for @adityab

peitschie added a commit to peitschie/WebODF that referenced this issue Sep 17, 2014
As per design discussed in issue webodf#816. Extracting this into a separate
view makes it optional for consumers to use (or potentially further
customize).

Fixes webodf#816.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 17, 2014
As per design discussed in issue webodf#816. Extracting this into a separate
view makes it optional for consumers to use (or potentially further
customize).

Fixes webodf#816.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants