Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider update #267

Closed
wants to merge 6 commits into from
Closed

Slider update #267

wants to merge 6 commits into from

Conversation

koenbok
Copy link
Owner

@koenbok koenbok commented Dec 14, 2015

@benjaminnathan please describe what is happenjah.

Benjamin den Boer added 5 commits November 27, 2015 15:51
…tion which offsets the pointForValue and valueForPoint modulates
…e tap-target of the sliderComponent, with automatic matching of borderRadius and positioning
… sliders that are also bounded, and update the dragging constraints of vertical bounded sliders
@jordandobson
Copy link
Contributor

I wonder if you could also inlcude in this PR the ability to have the "change:value" event fire when the value is set and thus changes @benjaminnathan. Currently you end up having to listen to the slider.knob "change:x" event... :(

@marckrenn
Copy link
Contributor

Hey guys,
This should fix the problem mentioned by @jordandobson:

http://share.framerjs.com/89mt081dckxo/

I'm just too stupid to figure out how to commit to a branch ...

Edit: #270

@@ -0,0 +1,3 @@
{
"directory" : "plugins"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koenbok think I heard you mention that we're no longer using Bower, correct?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, took it out, we no get all our test deps from npm directly.

@benjamindenboer
Copy link
Collaborator

Thanks for all of your input, guys. I'll bring all of this together, update the .gitignore, fix current issues and will create a new overview outlining all changes there. (This is getting a little hard to manage)

cc @jordandobson @marckrenn @koenbok @edwinvanrijkom

@benjamindenboer
Copy link
Collaborator

See overview here: #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants