Updated Roslyn analyzer nugets to support building in VS2022 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, Thanks! I'm a bit swamped at the moment but I can take a look at this over the weekend. Seems like a test is failing on mac for different reasons, will have to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this will not build in VS2022 because of this issue dotnet/roslyn-analyzers#5890.
There are two options to fix this, either avoid using the
new()type constructors for diagnostics or update the Roslyn analyzer package to the latest. I am open to doing either. Was hoping to work on a feature enhancement after I get this building correctly in VS2022.The edits to the files outside of the nuget updates was because of complaints from the new analyzers in the Roslyn package.