Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change authn and pprof api for container #3243

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

jamsman94
Copy link
Contributor

@jamsman94 jamsman94 commented Dec 11, 2023

What this PR does / Why we need it:

🤖[deprecated] Generated by Copilot at 26b5b2f

Moved pprof endpoints to /debug/pprof and updated authentication logic. This avoids conflicts with the API gateway and allows easier debugging of the Aslan service.

What is changed and how it works?

🤖[deprecated] Generated by Copilot at 26b5b2f

  • Move pprof endpoints to /debug/pprof to avoid conflicts and follow convention (link)
  • Allow unauthenticated GET requests to pprof endpoints by updating IsPublicURL function (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

Signed-off-by: Min Min <[email protected]>
@jamsman94 jamsman94 merged commit 9638981 into koderover:main Dec 11, 2023
4 checks passed
jamsman94 added a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant