Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importance scores for PLS models from the mixOmics package. #129

Merged
merged 1 commit into from
Sep 24, 2021
Merged

importance scores for PLS models from the mixOmics package. #129

merged 1 commit into from
Sep 24, 2021

Conversation

topepo
Copy link
Contributor

@topepo topepo commented Sep 24, 2021

No description provided.

@topepo
Copy link
Contributor Author

topepo commented Sep 24, 2021

CI errors are coming from mlr tests. Any ideas? Let me know if I need to change something.

@bgreenwell
Copy link
Member

@topepo Not sure why that's happening, but I'll look into it. In the ubuntu-20.04 (release) env, I'm also seeing Error: Package suggested but not available: ‘mixOmics’. Any thoughts there?

@topepo
Copy link
Contributor Author

topepo commented Sep 24, 2021

I'm not sure why it isn't installed in that configuration. If works for our packages that use it.

Can I update you r GutHub actions files in a different PR? That might be the difference?

@bgreenwell
Copy link
Member

Also, I'm going to merge this into the devel branch so I can manually run the tests and see what's going on with mlr.

@bgreenwell bgreenwell changed the base branch from master to devel September 24, 2021 16:22
@bgreenwell bgreenwell merged commit c42d011 into koalaverse:devel Sep 24, 2021
@topepo
Copy link
Contributor Author

topepo commented Sep 24, 2021

In case you haven't seen it, usethis::pr_fetch() is great for opening PR's locally.

@bgreenwell
Copy link
Member

@topepo, sorry for the long delay; I have a new book coming out and that has literally eaten into all of my spare time. In any case, the issue is coming from the mixOmics tests; in there, you use mixOmics::funs() but still load the package, which overwrites vip's vip() function with the one from mixOmics. I plan to merge this and push a new release to CRAN this weekend that fixes another bug that the CRAN maintainers pointed out.

Also, after the holiday, I plan to take a hard look at incorporating yardstick for the performance metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants