Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctx.request.origin is wrong #1174

Closed
p3x-robot opened this issue Apr 16, 2018 · 2 comments · Fixed by #1262
Closed

ctx.request.origin is wrong #1174

p3x-robot opened this issue Apr 16, 2018 · 2 comments · Fixed by #1262

Comments

@p3x-robot
Copy link

Ciao!

How are you?

Weird output:

    app.use(ctx => {
        ctx.body = {
            hello: 'world',
            origin: ctx.request.origin,
        }
    })

image

image
@p3x-robot
Copy link
Author

Weird, with spdy, it works, with http2 is not.
with spdy it is correct:

image

@p3x-robot
Copy link
Author

i guess http2 expermintal....

mgjm added a commit to mgjm-fork/koa that referenced this issue Oct 19, 2018
@mgjm
fix: use :authority header of http2 requests as host (fixes koajs#1174)
350f5e1
@mgjm mgjm mentioned this issue Oct 19, 2018
Merged
fengmk2 pushed a commit that referenced this issue Oct 23, 2018
@mgjm @fengmk2
feat: use :authority header of http2 requests as host (#1262)
9c5c58b 
close #1174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use :authority header of http2 requests as host mgjm-fork/koa
1 participant
@p3x-robot