Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install without sudo #42

Merged
merged 1 commit into from
Jan 15, 2025
Merged

install without sudo #42

merged 1 commit into from
Jan 15, 2025

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jan 15, 2025

Fixes #23

@imjasonh imjasonh marked this pull request as ready for review January 15, 2025 15:27
@imjasonh imjasonh enabled auto-merge January 15, 2025 15:28
@imjasonh imjasonh merged commit d982fec into main Jan 15, 2025
3 checks passed
@cpanato cpanato deleted the imjasonh-patch-3 branch January 15, 2025 15:29
@bHacklv
Copy link

bHacklv commented Jan 21, 2025

Hi, this "fix" has broken our CI (after upgrading to v0.8, so we had to rollback to v0.7).

You should have parameterised sudo usage and allowed consumers to decide whether to use it or not.

Now with v0.8 I get this:

tar xzf - -C /usr/local/bin ko
tar: ko: Cannot open: Permission denied
tar: Exiting with failure status due to previous errors
Error: Process completed with exit code 2.

With v0.7 it was working fine

@dprotaso
Copy link

@bHacklv are you using vanilla github actions runners or something else like self hosted runners?

@cpanato
Copy link
Member

cpanato commented Jan 21, 2025

i can make a fix and make sudo an option to be used or not

@max-frank
Copy link

@dprotaso Experiencing the same issue and can report we have our own self hosted runners

@bHacklv
Copy link

bHacklv commented Jan 22, 2025

@bHacklv are you using vanilla github actions runners or something else like self hosted runners?

Private self-hosted, based on ghcr.io/actions/actions-runner.
I've tried with ubuntu-latest GH runner, and indeed, sudo is not required in that case.

@cpanato
Copy link
Member

cpanato commented Jan 22, 2025

@max-frank @bHacklv @dprotaso did this PR to fix the issue y'all are having #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid sudo
5 participants