wallet: Make GetOldestKeyPoolTime return nullopt for blank wallets

This change suppress the "keypoololdest" field in the getwalletinfo RPC response for blank descriptor wallets.
knst · Nov 3, 2021 · ee03c78 · ee03c78
1 parent 3e4f069
commit ee03c78
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2172,6 +2172,10 @@ bool CWallet::GetNewChangeDestination(const OutputType type, CTxDestination& des
 std::optional<int64_t> CWallet::GetOldestKeyPoolTime() const
 {
     LOCK(cs_wallet);
+    if (m_spk_managers.empty()) {
+        return std::nullopt;
+    }
+
     std::optional<int64_t> oldest_key{std::numeric_limits<int64_t>::max()};
     for (const auto& spk_man_pair : m_spk_managers) {
         oldest_key = std::min(oldest_key, spk_man_pair.second->GetOldestKeyPoolTime());