Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to chroot(2) as part of the daemon process #22

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

worr
Copy link
Contributor

@worr worr commented Dec 25, 2017

This allows daemon processes to chroot into different directories so that
they're sandboxed off from the rest of the filesystem. This adds a little bit
of cross-platform fs isolation that's common in many OpenBSD-produced daemons.

@knsd
Copy link
Owner

knsd commented Dec 25, 2017

Hi, thanks for your contribution!

As far as I can see, you perform chroot syscall after dropping privileges, is it a bug?

This allows daemon processes to chroot into different directories so that
they're sandboxed off from the rest of the filesystem. This adds a little bit
of cross-platform fs isolation that's common in many OpenBSD-produced daemons.
@worr
Copy link
Contributor Author

worr commented Dec 25, 2017

Hey there! Totally an oversight on my end.

I've added a bit to the example that I used to test to ensure that this doesn't get missed in the future.

@knsd knsd merged commit 865cb3e into knsd:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants