Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Symfony 4.x support #443

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Jun 11, 2024

  • Removes support for Symfony 4.x
  • Bumps minimum supported Symfony version to 5.4
  • fixes incorrect symfony/security-guard constraint (version 6+ doesn't exist)

@jrushlow jrushlow added Status: Needs Work Additional work is needed Feature New Feature labels Jun 11, 2024
composer.json Outdated Show resolved Hide resolved
@jrushlow jrushlow force-pushed the feature/drop-legacy-symfony branch from 19d81ed to fc062e6 Compare June 12, 2024 12:03
"symfony/security-guard": "^4.4|^5.0|^6.0|^7.0",
"symfony/yaml": "^4.4|^5.0|^6.0|^7.0"
"symfony/phpunit-bridge": "^5.4|^6.0|^7.0",
"symfony/security-guard": "^5.4",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - there is no 6+ version of symfony/security-guard

@jrushlow jrushlow changed the title WIP - drop legacy symfony versions drop Symfony 4.x support Jun 12, 2024
@jrushlow jrushlow added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Jun 12, 2024
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@jrushlow jrushlow merged commit f39663e into knpuniversity:main Jun 14, 2024
9 checks passed
@jrushlow jrushlow deleted the feature/drop-legacy-symfony branch June 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants