Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality “Fetching access keys via OAuth2 to be used with an API” mentioned in the README does not necessarily need a
redirect_url
, thus providing it should not be mandatory. We have an Endpoint (pingen.com) which does not allowredirect_url
to be sent in these cases. Also, it wouldn't make much sense if it did because the route must be a valid symfony route, which in some cases must be created without a use.I also think it makes sense to allow
null
here because this parameter isn't mandatory in theLeague\OAuth2\Client\ProviderAbstractProvider
(https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php#L454).