Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 to GitHub actions #336

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

DonCallisto
Copy link
Contributor

As PHP 8.1 will be out shortly and since this bundle claims to support a vast range oh PHP versions, I think it's good to add a build for PHP 8.1 also.

@DonCallisto
Copy link
Contributor Author

I also think it's time to drop some older versions.
PHP 7.1 ended nearly two years ago.

@weaverryan
Copy link
Member

Thanks @DonCallisto! About 7.1, we could remove that, but if it doesn't cause any issues, I'm not in a rush. In a perfect world, I like to have our libraries support the PHP version of the Symfony LTS. Right now that is 4.4 and PHP 7.1, though 5.4 will be released in November, and then we can at least jump to 7.2. But that's not a strict rule: as soon as old versions cause any real complication, we can jump beyond them.

@weaverryan weaverryan merged commit acd2494 into knpuniversity:master Oct 17, 2021
@DonCallisto
Copy link
Contributor Author

DonCallisto commented Oct 18, 2021

You got a point here. Didn't thought about PHP versions supported by Symfony itself.

@jrushlow jrushlow added the Minor Minor Enhancement label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants