Share some of the common logic for issuing requests. #6334
Conversation
Factors a small library for making a GET request to produce a RuntimeInfo. Also add a small debug dumping utility on failures, the hope of consolidating some of this is to have a common point for instrumenting as we chase 404s.
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
/lgtm |
🙄 /retest |
| func DumpResponse(t *testing.T, resp *http.Response) { | ||
| t.Helper() | ||
|
|
||
| t.Logf("%s %d %s", resp.Proto, resp.StatusCode, resp.Status) |
There was a problem hiding this comment.
Dumping both status and status code seem redundant, since Status=200 oK.
There was a problem hiding this comment.
Yeah, it is. I'd like to get this in so we get more verbose flake tracing, and have a few improvements to make here already. 🤓
There was a problem hiding this comment.
There was a problem hiding this comment.
If this flakes again, I'll just push them here, I've got it ready
There was a problem hiding this comment.
🤔 I wonder if these threats scare our flakes into hiding 🤣
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Factors a small library for making a GET request to produce a RuntimeInfo.
Also add a small debug dumping utility on failures, the hope of consolidating some of this is to have a common point for instrumenting as we chase 404s.