Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop replace directives for incoming lib bumps #15777

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

dprotaso
Copy link
Member

Fixes #

Proposed Changes

Release Note

Minimum Kubernetes version is now v1.31

@dprotaso
Copy link
Member Author

/assign @skonto

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 13, 2025
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto February 13, 2025 17:06
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (3f7fd94) to head (61d762b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15777      +/-   ##
==========================================
- Coverage   80.81%   80.80%   -0.02%     
==========================================
  Files         222      222              
  Lines       18075    18075              
==========================================
- Hits        14608    14606       -2     
- Misses       3096     3098       +2     
  Partials      371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/hold

this needs some codegen fixes in knative/pkg#3149

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@skonto
Copy link
Contributor

skonto commented Feb 17, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
Copy link

knative-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor

skonto commented Feb 17, 2025

@dprotaso We need to make a call about:

 Error: pkg/reconciler/route/route.go:372:3: error is not nil (line 370) but it returns nil (nilerr)
  		return nil, nil
  		^
  1 issues:
  * nilerr: 1

@skonto
Copy link
Contributor

skonto commented Feb 17, 2025

/override ?

Copy link

knative-prow bot commented Feb 17, 2025

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • License Compliance
  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • style / Golang / Lint
  • style / suggester / github_actions
  • tide
  • unit-tests_serving_main
  • upgrade-tests_serving_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Feb 17, 2025

/override "style / Golang / Lint"

Copy link

knative-prow bot commented Feb 17, 2025

@skonto: Overrode contexts on behalf of skonto: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 02800e8 into knative:main Feb 17, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants