Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Fix configuration timeout defaulting #15721

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15617

NONE

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@knative-prow knative-prow bot requested review from izabelacg and ReToCode January 21, 2025 18:40
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (06bb3a7) to head (446cc82).
Report is 1 commits behind head on release-1.16.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16   #15721      +/-   ##
================================================
- Coverage         83.52%   83.50%   -0.03%     
================================================
  Files               219      219              
  Lines             17455    17462       +7     
================================================
+ Hits              14580    14582       +2     
- Misses             2502     2507       +5     
  Partials            373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jan 21, 2025

Kourier tls runtime fails since 1.16.

@skonto
Copy link
Contributor

skonto commented Jan 21, 2025

/override ?

Copy link

knative-prow bot commented Jan 21, 2025

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • License Compliance
  • build-tests_serving_release-1.16
  • istio-latest-no-mesh-tls_serving_release-1.16
  • istio-latest-no-mesh_serving_release-1.16
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • test (v1.28.x, kourier-tls, runtime)
  • test (v1.29.x, kourier-tls, runtime)
  • tide
  • unit-tests_serving_release-1.16
  • upgrade-tests_serving_release-1.16

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Jan 21, 2025

/override "test (v1.28.x, kourier-tls, runtime)"
/override "test (v1.29.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 21, 2025

@skonto: Overrode contexts on behalf of skonto: test (v1.28.x, kourier-tls, runtime), test (v1.29.x, kourier-tls, runtime)

In response to this:

/override "test (v1.28.x, kourier-tls, runtime)"
/override "test (v1.29.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Jan 21, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@dprotaso
Copy link
Member

/approve
/override "test (v1.28.x, kourier-tls, runtime)"
/override "test (v1.29.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 22, 2025

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • test (v1.28.x, kourier-tls, runtime)
  • test (v1.29.x, kourier-tls, runtime)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • License Compliance
  • build-tests_serving_release-1.16
  • istio-latest-no-mesh-tls_serving_release-1.16
  • istio-latest-no-mesh_serving_release-1.16
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_serving_release-1.16
  • upgrade-tests_serving_release-1.16

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/approve
/override "test (v1.28.x, kourier-tls, runtime)"
/override "test (v1.29.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@knative-prow knative-prow bot merged commit 674f624 into knative:release-1.16 Jan 22, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants