-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.16] Fix configuration timeout defaulting #15721
[release-1.16] Fix configuration timeout defaulting #15721
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #15721 +/- ##
================================================
- Coverage 83.52% 83.50% -0.03%
================================================
Files 219 219
Lines 17455 17462 +7
================================================
+ Hits 14580 14582 +2
- Misses 2502 2507 +5
Partials 373 373 ☔ View full report in Codecov by Sentry. |
Kourier tls runtime fails since 1.16. |
/override ? |
@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "test (v1.28.x, kourier-tls, runtime)" |
@skonto: Overrode contexts on behalf of skonto: test (v1.28.x, kourier-tls, runtime), test (v1.29.x, kourier-tls, runtime) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/approve |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
674f624
into
knative:release-1.16
This is an automated cherry-pick of #15617