Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set seccomp profile in the queue proxy #13507

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 24, 2022

Fixes: #13471

Don't set the container's `SeccompProfile.Type` as it may break upgrade

This is breaking OpenShift and likewise people using gVisor
@knative-prow knative-prow bot added the area/API API objects and controllers label Nov 24, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2022
@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 86.44% // Head: 86.45% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7363ab1) compared to base (e17e4d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13507   +/-   ##
=======================================
  Coverage   86.44%   86.45%           
=======================================
  Files         196      196           
  Lines       14600    14600           
=======================================
+ Hits        12621    12622    +1     
  Misses       1678     1678           
+ Partials      301      300    -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/resources/queue.go 98.25% <ø> (ø)
pkg/autoscaler/statserver/server.go 75.91% <0.00%> (-1.46%) ⬇️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso dprotaso added this to the v1.9.0 milestone Nov 24, 2022
@dprotaso
Copy link
Member Author

/cherry-pick release-1.8

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 2ba4499 into knative:main Nov 24, 2022
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #13508

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seccomp profile in queue-proxy incompatible with gvisor
3 participants