func-go v1.21.3 - idiomatic handler signatures #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
/hold for @lkingland |
knative-prow
bot
added
the
do-not-merge/hold
|
/assign @lkingland |
dprotaso
force-pushed
the
update-go-http-templates
branch
from
f3dbc6a to
2791153
Compare
dprotaso
force-pushed
the
update-go-http-templates
branch
from
2791153 to
82212bf
Compare
Since the Pack and S2I builders do not yet use the new func-go middleware, we are not yet able update the static static handler template.
knative-prow
bot
added
size/L
Closed
lkingland
changed the title
lkingland
force-pushed
the
update-go-http-templates
branch
from
dbf25b6 to
bd4e7b8
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is paired with the changes here knative-extensions/func-go#58