-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Go and Rust on cluster build is supported #1923
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 61.85% 62.78% +0.92%
==========================================
Files 107 107
Lines 13813 13814 +1
==========================================
+ Hits 8544 8673 +129
+ Misses 4415 4262 -153
- Partials 854 879 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PTAL @jrangelramos |
this can be removed, since its not relevant anymore: func/docs/building-functions/on_cluster_build.md Lines 39 to 43 in 76f09c6
|
would it make sense to add some documentation around why we are using knative custom jammy builders instead of paketo base? |
Signed-off-by: Matej Vasek <[email protected]>
Jammy is now the paketo builder. The previous one has been deprecated. |
What do you mean? @Shashankft9 |
What I mean is https://github.com/paketo-buildpacks/base-builder says:
|
I don't think we need to justify our builder IMO. |
PTAL @jrangelramos |
Signed-off-by: Matej Vasek <[email protected]>
PTAL @Shashankft9 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, Shashankft9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* doc: Go and Rust on cluster build is supported Signed-off-by: Matej Vasek <[email protected]> * doc: build envvars Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]>
* doc: Go and Rust on cluster build is supported Signed-off-by: Matej Vasek <[email protected]> * doc: build envvars Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]>
* chore: use tkn tasks from PR branch in CI (#1914) Signed-off-by: Matej Vasek <[email protected]> * chore: released binaries refer correct task yamls (#1916) Signed-off-by: Matej Vasek <[email protected]> * chore: refer correct tkn yaml in prow test (#1918) Without this change prow test will refer tkn yamls from the main branch not from the PR head branch. Signed-off-by: Matej Vasek <[email protected]> * chore: update release generation (#1924) * Minimize release binary size. * Release latest version of buildpack tekton task. Signed-off-by: Matej Vasek <[email protected]> * test: update github ref used on e2e oncluster tests (#1917) * test: Split of GH oncluster tests by builder. Added FUNC_BUILDER env var for e2e oncluter tests (#1963) * Use our own s2i image (#1971) Our image is much more recent and it is multiarch. Signed-off-by: Matej Vasek <[email protected]> * chore: update buildah image ref (#1960) Signed-off-by: Matej Vasek <[email protected]> * chore: update CA certs (#1944) Signed-off-by: Matej Vasek <[email protected]> * chore: update Quarkus platform version to 3.4.1 (#1989) Co-authored-by: Knative Automation <[email protected]> Signed-off-by: Matej Vasek <[email protected]> * chore: update mvn wrapper in Quarkus template (#1987) Signed-off-by: Matej Vasek <[email protected]> * chore: use ./mvnw not mvn in tests (#1988) Signed-off-by: Matej Vasek <[email protected]> * chore: update Springboot platform version Signed-off-by: Matej Vasek <[email protected]> * fix: docker registry/repository parsing (#1929) * fix: docker registry/repository parsing Use go-containerregistry to do parsing. Signed-off-by: Matej Vasek <[email protected]> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <[email protected]> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * Fix failing concurrent test on Windows (#1890) * src: better debugging Signed-off-by: Matej Vasek <[email protected]> * fix: wait for both builds Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fix: detection of process liveness on Windows Signed-off-by: Matej Vasek <[email protected]> * fix: make symlink relative Signed-off-by: Matej Vasek <[email protected]> * fixup: cleanup Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * allowing on cluster build for go runtime (#1445) * allowing on cluster build for go runtime * warning message added for go and rust builder * gofmt * fixups Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> Co-authored-by: Matej Vasek <[email protected]> * Use custom jammy paketo builder (#1911) * chore: use custom jammy paketo builder Use our own modified jammy builder with additional buildpacks for GoFunc and Rust. This enables on cluster build for Go and Rust functions. Where possible (Go, Java) we use "tiny" variant, other runtimes use "base" variant. The updated task is new file instead of modifying existing task this is done for sake of keeping compatiblility. Signed-off-by: Matej Vasek <[email protected]> * fixup: remove unnecessary code per review request Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup: podman test refers correct tkn task yamls Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * doc: Go and Rust on cluster build is supported (#1923) * doc: Go and Rust on cluster build is supported Signed-off-by: Matej Vasek <[email protected]> * doc: build envvars Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * fix: direct upload ppc64le, x390x (#1958) Signed-off-by: Matej Vasek <[email protected]> * fix: report correct error when task doesn't exist (#1915) Signed-off-by: Matej Vasek <[email protected]> * feat: tekton task urls in the env sub-cmd output (#1925) Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> Co-authored-by: Jefferson Ramos <[email protected]> Co-authored-by: Knative Automation <[email protected]> Co-authored-by: Shashank Sharma <[email protected]>
Changes
Update doc: Go and Rust on cluster build is supported.