Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

remove old cruft #1678

Merged
merged 1 commit into from
Feb 4, 2021
Merged

remove old cruft #1678

merged 1 commit into from
Feb 4, 2021

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Feb 4, 2021

Proposed Changes

  • Remove left over deps that are no longer necessary. These were missed when things were moved out to knative-sandbox repos.

Release Note

:broom: remove bunch of unnecessary deps that are no longer necessary.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 4, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release labels Feb 4, 2021
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
matzew
matzew approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 28bbd26 into knative:master Feb 4, 2021
@vaikas vaikas deleted the deps branch February 4, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew approved these changes

@coryrc coryrc Awaiting requested review from coryrc

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaikas @knative-prow-robot @matzew