Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Removing nachocano from approvers/reviewers #1669

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Removing nachocano from approvers/reviewers #1669

merged 1 commit into from
Nov 20, 2020

Conversation

nachocano
Copy link
Contributor

Proposed Changes

  • Removing myself from approvers and reviewers as I'll be mainly working on other project(s).

Release Note

NONE

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 19, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2020
@nachocano
Copy link
Contributor Author

/assign @n3wscott

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@matzew
Copy link
Member

matzew commented Nov 20, 2020

😢
/lgtm
No, does NOT look good to me!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@knative-prow-robot knative-prow-robot merged commit 3e40c7d into knative:master Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pierDipi pierDipi Awaiting requested review from pierDipi

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@matzew matzew

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nachocano @knative-prow-robot @matzew @n3wscott