Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Istio with Knative Brokers #5268

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Integrating Istio with Knative Brokers #5268

merged 3 commits into from
Oct 13, 2022

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 10, 2022 •
edited
Loading

@abrennan89 abrennan89 requested a review from matzew October 10, 2022 19:17
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c3dd77
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6345974f7e998b0008c90756
😎 Deploy Preview https://deploy-preview-5268--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 10, 2022
@matzew
Copy link
Member

matzew commented Oct 11, 2022

The istio part looks good!

/lgtm
/approve

/hold

feel free to unhold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Oct 11, 2022

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@abrennan89 abrennan89 requested a review from matzew October 11, 2022 16:23
@abrennan89
Copy link
Contributor Author

/cherrypick release-1.7

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented Oct 13, 2022

LGTM

@abrennan89 abrennan89 added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@knative-prow knative-prow bot merged commit 99ae375 into knative:main Oct 13, 2022
@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5274

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc request: Describe User Authentication with Istio for the Knative broker
3 participants
@abrennan89 @matzew @knative-prow-robot