Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup broker docs and snippets #5193

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Cleanup broker docs and snippets #5193

merged 6 commits into from
Aug 31, 2022

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Aug 26, 2022 •
edited
Loading

Related to #4069
Fixes #5106

Proposed Changes

  • Add Broker, Trigger, Subscriber snippets
  • Add brokers to Concepts docs section
  • Clean up existing broker docs
  • Cleanup tutorial broker section
  • Move triggers to own docs under Resources, Concepts
  • Add broker types docs section

Direct docs preview links:

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@netlify
Copy link

netlify bot commented Aug 26, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7702230
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/630fa1f1df5d0500084c4627
😎 Deploy Preview https://deploy-preview-5193--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@abrennan89 abrennan89 force-pushed the ConceptSnippets branch 2 times, most recently from 6dbe455 to 39646ac Compare August 30, 2022 17:36
@abrennan89 abrennan89 changed the title [WIP] Cleanup broker docs and snippets Cleanup broker docs and snippets Aug 30, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@abrennan89 abrennan89 requested a review from snneji August 31, 2022 16:06
@abrennan89
Copy link
Contributor Author

@knative/eventing-reviewers @knative/eventing-wg-leads can I get a review for this PR please

lionelvillard
lionelvillard reviewed Aug 31, 2022
View reviewed changes
config/nav.yml Outdated Show resolved Hide resolved
lionelvillard
lionelvillard reviewed Aug 31, 2022
View reviewed changes
config/nav.yml Outdated Show resolved Hide resolved
@lionelvillard
Copy link
Member

I added some comments

@abrennan89
Copy link
Contributor Author

@lionelvillard if you're OK with it can you lgtm this please (if the content etc looks fine). I don't want to hold it up if we can help it because it's blocking other work I'd like to do around broker configs, moving other Resources etc. 🙂

@abrennan89
Copy link
Contributor Author

/cherrypick release-1.7

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lionelvillard
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@knative-prow knative-prow bot merged commit 2498912 into knative:main Aug 31, 2022
@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5208

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snneji snneji Awaiting requested review from snneji

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Brokers to own top lvl section in Eventing
3 participants
@abrennan89 @lionelvillard @knative-prow-robot