Add to pingsource.md #3476

RichardJJG · 2021-04-19T11:18:01Z

Added material from this Google Doc:

https://docs.google.com/document/d/1V_6Cjqbt0khUhewXnT_3_Hc2L0RDFThy4lHo8z-sEQ8/edit#heading=h.wowd2jl072p0

Added material from this Google Doc: https://docs.google.com/document/d/1V_6Cjqbt0khUhewXnT_3_Hc2L0RDFThy4lHo8z-sEQ8/edit#heading=h.wowd2jl072p0

abrennan89 · 2021-04-19T12:33:52Z

docs/eventing/sources/pingsource.md

 type: "docs"
+aliases:
+  - ../cronjob-source


I think this needs to be an absolute link, e.g. /docs/whatever/path

Given no alias was present before (I think it was added through some merging accident) I'll simply delete it.

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:37:31Z

docs/eventing/sources/pingsource.md


-The PingSource source type is enabled by default when you install Knative Eventing.
+## Overview


I really don't like overview as a heading - can we just move all the context info to above the "before you begin" instead? That way we're also not mixing steps / instructions and contextual info.

abrennan89 · 2021-04-19T12:38:27Z

docs/eventing/sources/pingsource.md

+In event-driven architecture the most straightforward use case is a producer creating an event and a
+consumer acting on that event.


I don't think this needs to be repeated since we have "This topic explains event-driven architecture..." above. I'd choose one and remove the other. I think the previous statement is better but its up to you.

Okay, will do.

abrennan89 · 2021-04-19T12:39:34Z

docs/eventing/sources/pingsource.md

+### Producers

-### Creating a namespace
+Producers create events. Using GitHub as an example, the producer is the GitHub webhook that sends
+information when a pull request is created.
+Essentially, you ask the producer for events that they are capable of sending and you tell the
+producer where to send those events.

-Create a new namespace called `pingsource-example` by entering the following
-command:
+Producers send the event data per specifications that make it easy for consumers to handle it.
+Knative uses the CloudEvents specifications by default.
+For more information, see the [Cloud Events](https://cloudevents.io/) website.


I don't really think this belongs here honestly, I think all of this info about event-driven etc should be in a main, generic section about event sources, not preceding a procedure on creating an example PingSource?

@omerbensaadon wants it here, AFAIK. We could (should?) re-title this as more of a Getting Started document than a reference topic for PingSource buried way down the subnav.

@abrennan89, it's good content regardless. Where would you rather it be placed?

https://knative.dev/development/concepts/ maybe? Or the main eventing landing page, but both of those require cleanup first. FWIW there's a task for producers and consumers as part of #1923, so I'd do it as part of that rather than adding to pingsource.

Since we don't have a place for this text right now, would it unblock this PR to add a  here?

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:40:47Z

docs/eventing/sources/pingsource.md


-To deploy the `event-display` consumer to your cluster, run the following
-command:
+## Create a consumer (Knative service)


Let's not use parentheses in headings, especially since there are many types of consumers not just a ksvc.
It's explained that it's a service in the next paragraph so there's no need to have it here IMO.

abrennan89 · 2021-04-19T12:41:28Z

docs/eventing/sources/pingsource.md

+To create a consumer, and verify that `PingSource` is working, create a simple Knative service that
+receives CloudEvents and writes them to stdout.


Formatting - either use PingSource or PingSource, cc @omerbensaadon for style guide. Again, if we're going with the k8s, I'd leave out the backticks.

I'll drop the backticks.

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:43:34Z

docs/eventing/sources/pingsource.md

-  replicas: 1
-  selector:
-    matchLabels: &labels
-      app: event-display
  template:
-    metadata:
-      labels: *labels
    spec:
      containers:
-        - name: event-display
-          image: gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display
+        - image: gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display


Why remove all of this instead of explaining it?
Also, is it not event-display? I could be wrong but would check this with eng.

I received the much abridged example from the Google doc the engineer wrote; I've not deviated from what the engineer wants.

Also, good catch -- @vaikas, this should be event-display rather than event_display, right?

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:45:18Z

docs/eventing/sources/pingsource.md

-    targetPort: 8080
-EOF
+```shell
+kn service create event-display --image gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display


again, I'd check this image isn't event-display rather than event_display

event-display rather than event_display, right, @vaikas?

abrennan89 · 2021-04-19T12:48:02Z

docs/eventing/sources/pingsource.md

+{{< /tab >}}
+{{< /tabs >}}
+
+## Create a producer (PingSource)


Again, remove parentheses, I don't think there's a need to even mention concepts like producer vs consumer in this doc honestly w/ the exception of if you're explaining them as concepts. I'd just say "Create a PingSource"

@omerbensaadon can we also decide whether to use gerunds in headings please in the style guide. It might be nice if we could have something like the IBM style guide IMO as a reference but idk how licensing and funding for that would work upstream.

The idea is to add just enough conceptual information to put the reader at better ease with the procedure. I can drop the parentheses, though. I like them as a hand-holding way of walking through what's actually going on, but I can see how the reader might think PingSource is the de facto producer.

abrennan89 · 2021-04-19T12:53:17Z

docs/eventing/sources/pingsource.md

+Create a producer (PingSource) that sends events to your consumer every two minutes.
+The `sink` element in the metadata describes where to send events.
+In this case, events are sent to a service with the name `event-display`.
+This is a tight connection between the producer and consumer.


Again, remove parentheses. Feels over-explained.
I don't think these all need to be separate lines either, it could just be a paragraph? The flow just feels off here IMO.

I think in general this includes too much context between steps of a procedure - IMO all the conceptual info should go in a generic event sources concept doc and the steps should be in a simple procedural topic.
Also, rather than explaining things like sink here, can we use the callout workaround style that was established; https://docs.google.com/document/d/1tigolRzKhronvgoAJfszE-XHWWd0LQ8o_j0D73O9KvM/edit#heading=h.ka7avn97fckt

Okay, I'll cut back a bit.

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:55:40Z

docs/eventing/sources/pingsource.md

 ```
-
 {{< /tab >}}
 {{< /tabs >}}

 ## (Optional) Create a PingSource with binary data


I'd make this its own section instead of being optional in an example. By the time a reader gets to here they've created a PingSource with the other methods. Also, please no more parentheses in titles 😂

Yep, makes sense, thanks.

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T12:58:04Z

docs/eventing/sources/pingsource.md


-Please note that `data` and `dataBase64` cannot co-exist.
+**Note:** `data` and `dataBase64` cannot co-exist.


Suggested change

**Note:** `data` and `dataBase64` cannot co-exist.

**NOTE:** You can use either `data` or `dataBase64`, but not both.

Explain why?

@lionelvillard, why can't you use both?

ping @lionelvillard

Both data and dataBase64 specify the CloudEvent payload, that's why those fields are mutually-exclusive.

Does that answer your question?

Maybe the following text, to clarify why:

**NOTE:** Because both `data` and `dataBase64` specify the event payload, only one field may be set.

abrennan89 · 2021-04-19T12:59:17Z

docs/eventing/sources/pingsource.md

-Please note that `data` and `dataBase64` cannot co-exist.
+**Note:** `data` and `dataBase64` cannot co-exist.
+
+Create the event source with binary data from stdin by running:


I'd just use PingSource throughout > event source

I think things like stdin that refer to something specific should always be in back ticks, and I really think we should explain this cos I don't know what it is. At least maybe add a link explaining it.

I've just added code formatting rules to the Style Guide, which people are free to support/dispute.

abrennan89 · 2021-04-19T12:59:55Z

docs/eventing/sources/pingsource.md

+{{< tabs name="view-event" default="kubectl" >}}
+{{% tab name="kubectl" %}}
+
+View the logs of the event-display service by running:


Be consistent with names - event-display

Good catch, thanks.

don't forget the backticks, not sure why these were removed

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-19T13:02:10Z

docs/eventing/sources/pingsource.md

-### Cleanup
+## Clean up
+
+Delete the PingSource instance:


I'd remove this because it's duplicated in the tabs

I'll delete the duplicate within the tabs.

docs/eventing/sources/pingsource.md

Co-authored-by: Ashleigh Brennan <[email protected]>

abrennan89 · 2021-04-22T12:52:55Z

Re the comments above, can we go with "by entering the command:" rather than "by running"? Otherwise a good point about accessibility @RichardJJG

Co-authored-by: Ashleigh Brennan <[email protected]>

RichardJJG · 2021-04-27T09:39:24Z

Re the comments above, can we go with "by entering the command:" rather than "by running"? Otherwise a good point about accessibility @RichardJJG

Why do you prefer the wordier "by entering the command:", @abrennan89?
I've written a "Documenting Commands" section in the style guide, by the way, that makes the case for "running". We can change it to "by entering the command" if that's the better option.

abrennan89 · 2021-04-27T14:11:41Z

@RichardJJG I think they're both equally valid and it's mostly personal preference (FWIW I'm not sure there's a better case for using "run" based on what's in the style guide atm?), however I'd prefer:
"To [do X], enter the command:"
over “X the Y by running:”

We should probably base a decision on what would be easier for non-native speakers / translation down the road, which I believe would be "enter", but we probably need some research to make an informed decision about that. @omerbensaadon can you help with this?

knative-prow-robot · 2021-04-27T14:37:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign n3wscott after the PR has been reviewed.
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docs/eventing/sources/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot · 2021-04-27T14:37:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign n3wscott after the PR has been reviewed.
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docs/eventing/sources/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abrennan89

Added comments.

Q: Was the install stuff added to this PR by mistake?

abrennan89 · 2021-04-27T14:17:16Z

docs/eventing/sources/pingsource.md

+### Producers

-### Creating a namespace
+Producers create events. Using GitHub as an example, the producer is the GitHub webhook that sends
+information when a pull request is created.
+Essentially, you ask the producer for events that they are capable of sending and you tell the
+producer where to send those events.

-Create a new namespace called `pingsource-example` by entering the following
-command:
+Producers send the event data per specifications that make it easy for consumers to handle it.
+Knative uses the CloudEvents specifications by default.
+For more information, see the [Cloud Events](https://cloudevents.io/) website.


https://knative.dev/development/concepts/ maybe? Or the main eventing landing page, but both of those require cleanup first. FWIW there's a task for producers and consumers as part of #1923, so I'd do it as part of that rather than adding to pingsource.

docs/eventing/sources/pingsource.md

abrennan89 · 2021-04-27T14:27:06Z

docs/eventing/sources/pingsource.md


 ```shell
-kubectl create -n pingsource-example -f - <<EOF
-apiVersion: sources.knative.dev/v1beta2
+cat <<EOF | kubectl create -f -


same as above

abrennan89 · 2021-04-27T14:27:26Z

docs/eventing/sources/pingsource.md


-Please note that `data` and `dataBase64` cannot co-exist.
+**Note:** `data` and `dataBase64` cannot co-exist.


ping @lionelvillard

abrennan89 · 2021-04-27T14:34:19Z

docs/eventing/sources/pingsource.md


-See the [PingSource specification](../../reference/api/eventing/#sources.knative.dev/v1beta2.PingSource).
+Run:


same as above

abrennan89 · 2021-04-27T14:35:08Z

docs/install/any-kubernetes-cluster.md

+
+## Prerequisites
+
+Before installation, you must meet the following prerequisites:


Suggested change

Before installation, you must meet the following prerequisites:

Before you install Knative, ensure that:

Just a less wordy suggestion

abrennan89 · 2021-04-27T14:35:39Z

docs/install/any-kubernetes-cluster.md

+## Installing the Serving component
+
+To install the serving component:


I thought per the word list we're using Knative Serving throughout now?

abrennan89 · 2021-04-27T14:36:19Z

docs/install/any-kubernetes-cluster.md

+   kubectl set env --namespace ambassador  deployments/ambassador AMBASSADOR_KNATIVE_SUPPORT=true
+   ```
+
+1. To configure Knative Serving to use Ambassador by default:


Suggested change

1. To configure Knative Serving to use Ambassador by default:

1. To configure Knative Serving to use Ambassador by default, enter the command:

All the procedure steps in this part don't seem to have "run" or "enter" the command. In future I'd maybe keep this as a separate PR to the pingsource stuff, i.e. keep topics separated so it doesn't blur the PR scope

abrennan89 · 2021-04-27T14:38:00Z

docs/install/any-kubernetes-cluster.md

+## Installing the Eventing component
+
+To install the Eventing component:


same as above, Knative Eventing throughout?

evankanderson

/meow

For an extra "unnecessary cat".

evankanderson · 2021-04-27T19:06:49Z

docs/eventing/sources/pingsource.md


-Please note that `data` and `dataBase64` cannot co-exist.
+**Note:** `data` and `dataBase64` cannot co-exist.


Maybe the following text, to clarify why:

**NOTE:** Because both `data` and `dataBase64` specify the event payload, only one field may be set.

evankanderson · 2021-04-27T19:07:51Z

docs/eventing/sources/pingsource.md


-Please note that `data` and `dataBase64` cannot co-exist.
+Create the event source with binary data from standard in by running:


Alternatively, I might call this "stdin", "standard input" (weird, but what STDIN is abbreviated from) or "terminal input".

evankanderson · 2021-04-27T19:09:46Z

docs/eventing/sources/pingsource.md

+### Producers

-### Creating a namespace
+Producers create events. Using GitHub as an example, the producer is the GitHub webhook that sends
+information when a pull request is created.
+Essentially, you ask the producer for events that they are capable of sending and you tell the
+producer where to send those events.

-Create a new namespace called `pingsource-example` by entering the following
-command:
+Producers send the event data per specifications that make it easy for consumers to handle it.
+Knative uses the CloudEvents specifications by default.
+For more information, see the [Cloud Events](https://cloudevents.io/) website.


Since we don't have a place for this text right now, would it unblock this PR to add a  here?

docs/eventing/sources/pingsource.md

evankanderson · 2021-04-27T19:17:29Z

docs/eventing/sources/pingsource.md

+
+## Verify the message was sent
+
+Verify that the message was sent to the Knative Eventing system by looking at message dumper logs.


I was going to point out that Knative Services may scale down to zero and have their logs recycled, but it occurs to me that the PingSource might be firing just frequently enough to avoid this.

I suspect this will work whether or not the service is getting scaled down to zero because there will be at least one pod running with at least one request in the logs (because the pingsource keeps sending events), so this is mostly a note for other examples.

evankanderson · 2021-04-27T19:18:38Z

docs/eventing/sources/pingsource.md

+kail -l serving.knative.dev/service=event-display -c user-container --since=10m
+```
+
+For more information, see the [`kail`](https://github.com/boz/kail) repository in GitHub.


+1

You could also reference using log aggregation via https://knative.dev/docs/install/collecting-logs/ as another way to view the logs if desired, but I'm not super-happy with that yet so I don't want to add it to this PR.

knative-prow-robot · 2021-04-27T19:19:42Z

@evankanderson:

In response to this:

/meow

For an extra "unnecessary cat".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2021-04-27T19:48:50Z

@RichardJJG: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abrennan89 · 2021-04-28T14:56:18Z

Agreed with Richard to close this one in favor of #3509
TODO: I'll add another PR to move the conceptual info for producers etc

RichardJJG added 2 commits March 15, 2021 12:28

Fix comment indentation

75ba9ac

Add to pingsource.md

28f812d

Added material from this Google Doc: https://docs.google.com/document/d/1V_6Cjqbt0khUhewXnT_3_Hc2L0RDFThy4lHo8z-sEQ8/edit#heading=h.wowd2jl072p0

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2021

RichardJJG mentioned this pull request Apr 19, 2021

Clean up PingSource docs for eventing v1.0 #3366

Closed

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

abrennan89 reviewed Apr 19, 2021

View reviewed changes

docs/eventing/sources/pingsource.md Outdated Show resolved Hide resolved

knative-prow-robot assigned RichardJJG Apr 20, 2021

RichardJJG and others added 5 commits April 20, 2021 10:39

Update docs/eventing/sources/pingsource.md

24308bc

Co-authored-by: Ashleigh Brennan <[email protected]>

Update docs/eventing/sources/pingsource.md

d860d8f

Co-authored-by: Ashleigh Brennan <[email protected]>

Update docs/eventing/sources/pingsource.md

27722d7

Co-authored-by: Ashleigh Brennan <[email protected]>

Update docs/eventing/sources/pingsource.md

4a5c9bd

Co-authored-by: Ashleigh Brennan <[email protected]>

Merge branch 'patch-2' of github.com:RichardJJG/docs into patch-2

06842d8

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2021

knative deleted a comment from RichardJJG Apr 22, 2021

knative deleted a comment from lionelvillard Apr 22, 2021

RichardJJG and others added 4 commits April 26, 2021 12:07

Update docs/eventing/sources/pingsource.md

5718d70

Co-authored-by: Ashleigh Brennan <[email protected]>

Update docs/eventing/sources/pingsource.md

19e520d

Co-authored-by: Ashleigh Brennan <[email protected]>

[knative#3476] Revisions from review

26ca9cd

[knative#3476] Added header

cae7769

Delete any-kubernetes-cluster.md

d5c9f11

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2021

abrennan89 suggested changes Apr 27, 2021

View reviewed changes

evankanderson reviewed Apr 27, 2021

View reviewed changes

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2021

abrennan89 closed this Apr 28, 2021

abrennan89 mentioned this pull request Apr 28, 2021

Restructure "Eventing component" section #1923

Closed

5 tasks


		The PingSource source type is enabled by default when you install Knative Eventing.
		## Overview

		In event-driven architecture the most straightforward use case is a producer creating an event and a
		consumer acting on that event.

		To create a consumer, and verify that `PingSource` is working, create a simple Knative service that
		receives CloudEvents and writes them to stdout.


		Please note that `data` and `dataBase64` cannot co-exist.
		Note: `data` and `dataBase64` cannot co-exist.

	Note: `data` and `dataBase64` cannot co-exist.
	NOTE: You can use either `data` or `dataBase64`, but not both.


		See the [PingSource specification](../../reference/api/eventing/#sources.knative.dev/v1beta2.PingSource).
		Run:


		## Prerequisites

		Before installation, you must meet the following prerequisites:

	Before installation, you must meet the following prerequisites:
	Before you install Knative, ensure that:

		## Installing the Serving component

		To install the serving component:

	1. To configure Knative Serving to use Ambassador by default:
	1. To configure Knative Serving to use Ambassador by default, enter the command:

		## Installing the Eventing component

		To install the Eventing component:


		Please note that `data` and `dataBase64` cannot co-exist.
		Create the event source with binary data from standard in by running:


		## Verify the message was sent

		Verify that the message was sent to the Knative Eventing system by looking at message dumper logs.

Add to pingsource.md #3476

Add to pingsource.md #3476

Conversation

RichardJJG commented Apr 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrennan89 commented Apr 22, 2021

RichardJJG commented Apr 27, 2021 • edited Loading

abrennan89 commented Apr 27, 2021

knative-prow-robot commented Apr 27, 2021

knative-prow-robot commented Apr 27, 2021

abrennan89 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evankanderson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knative-prow-robot commented Apr 27, 2021

knative-prow-robot commented Apr 27, 2021

abrennan89 commented Apr 28, 2021

RichardJJG commented Apr 27, 2021 •

edited

Loading