Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backwards compatibility #63

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

lkingland
Copy link
Contributor

Fix backwards compatibility

Instanced functions use the new handler. Static functions will still requre the context argument until such time as this library is integrated into both Pack and S2I

Copy link

knative-prow bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from lance March 14, 2024 07:44
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@knative-prow knative-prow bot requested a review from matejvasek March 14, 2024 07:44
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
@lkingland lkingland changed the title backwards compatibility fix backwards compatibility Mar 14, 2024
@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@knative-extensions knative-extensions deleted a comment from knative-prow bot Mar 14, 2024
@knative-prow knative-prow bot merged commit 8c65371 into knative-extensions:main Mar 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant