improve image_finder speed by skipping mismatch label #1897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1896 の手当てです。
#1895 もこれで直るかと思います( #1895 自体は入れてよさそうな気はします)。
config['imagedir']
(つまりimages)を返していたのをやめて、config['imagedir']
の結果だけを返すようにしましたbuilder_init_file
)設定が呼び出されていなくて適切化されていないためです@book.image_types
)ようにしたので、ビルダ固有のものが使われるようになりました#1896 で報告される以前でも2000個くらいの画像を喰わせてみたときには止まってしまっていたのですが、このPRの適用では数秒で解決できています。
ただ、そこそこ広めに影響しそうなパッチなので、一応レビューいただければと思います。