Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.open時に「rt」フラグで改行コードをLFに統一する #1342

Merged
merged 1 commit into from
Jul 5, 2019
Merged

File.open時に「rt」フラグで改行コードをLFに統一する #1342

merged 1 commit into from
Jul 5, 2019

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Jul 4, 2019

#1341 の修正です。

書く環境と処理する環境がDocker利用などで異なるときに改行コードの違いが生じてしまうことがあるので、処理側でLFに統一させることにします。

@kmuto kmuto requested a review from takahashim July 4, 2019 14:44
takahashim
takahashim approved these changes Jul 5, 2019
View reviewed changes
Copy link
Collaborator

@takahashim takahashim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これで全部かどうかは未確認ですが、これ自体は入れて良さそうです。

@kmuto kmuto merged commit 6707fc5 into master Jul 5, 2019
@kmuto kmuto deleted the io-rt branch July 5, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahashim takahashim takahashim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmuto @takahashim